Repository navigation
feat: Let hosts dock the action menu to the top #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5e8dcc4
Let hosts dock the action menu to the top of the viewport
ivnnv dcd3347
Dock a top-placed action menu in the viewer toolbar row
ivnnv fb1444f
Top-align the viewer toolbar row
ivnnv 1d41837
Use a plain class string for the toolbar row
ivnnv 4f703eb
Keep the toolbar row usable when it runs out of width
ivnnv d6676e2
Place the wrapped menu beside tall side groups and keep overlays clear
ivnnv 25612a8
Reset the toolbar layout when the center group unmounts
ivnnv 5dd2291
Hint clears the whole toolbar; inspector drops the bottom gap with a …
ivnnv 07ebf18
Merge branch 'main' into action-menu-placement
ivnnv 169df3a
Merge remote-tracking branch 'upstream/main' into action-menu-placement
ivnnv ed648f4
Give the top-docked action menu its own row under the toolbar
ivnnv 986036a
Keep the level list over the top menu, and drop the inset when the me…
ivnnv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
packages/editor/src/components/ui/action-menu/placement.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { createContext, useContext } from 'react' | ||
|
|
||
| /** Viewport edge the action menu docks to. */ | ||
| export type ActionMenuPlacement = 'bottom' | 'top' | ||
|
|
||
| /** Where chrome under a top-docked menu starts: below the host toolbar row and the menu itself. */ | ||
| export const TOP_MENU_CLEARANCE = '7.25rem' | ||
|
|
||
| const ActionMenuPlacementContext = createContext<ActionMenuPlacement>('bottom') | ||
|
|
||
| export const ActionMenuPlacementProvider = ActionMenuPlacementContext.Provider | ||
|
|
||
| export function useActionMenuPlacement(): ActionMenuPlacement { | ||
| return useContext(ActionMenuPlacementContext) | ||
| } | ||
|
|
||
| /** Side tooltips and popovers open toward, away from the docked edge. */ | ||
| export function useActionMenuPopupSide(): 'top' | 'bottom' { | ||
| return useActionMenuPlacement() === 'top' ? 'bottom' : 'top' | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.