-
Notifications
You must be signed in to change notification settings - Fork 379
Description
With penta, the global vars that create these react-tokens that are used for custom styles will be removed, so we'll want to address that before penta is released (or whenever core removes the global vars and the react-tokens break).
The custom styles are used in the width modifiers example, but core has an equivalent example without custom styles, so I think we can just remove the custom stuff on the react side.
patternfly-react/packages/react-core/src/components/DataList/examples/DataList.md
Lines 26 to 29 in 3a88c11
| import global_Color_100 from '@patternfly/react-tokens/dist/esm/global_Color_100'; | |
| import global_BackgroundColor_200 from '@patternfly/react-tokens/dist/esm/global_BackgroundColor_200'; | |
| import global_BorderColor_100 from '@patternfly/react-tokens/dist/esm/global_BorderColor_100'; | |
| import global_BorderWidth_sm from '@patternfly/react-tokens/dist/esm/global_BorderWidth_sm'; |
patternfly-react/packages/react-core/src/components/DataList/examples/DataListWidthModifiers.tsx
Lines 23 to 26 in 3a88c11
| import global_Color_100 from '@patternfly/react-tokens/dist/esm/global_Color_100'; | |
| import global_BackgroundColor_200 from '@patternfly/react-tokens/dist/esm/global_BackgroundColor_200'; | |
| import global_BorderColor_100 from '@patternfly/react-tokens/dist/esm/global_BorderColor_100'; | |
| import global_BorderWidth_sm from '@patternfly/react-tokens/dist/esm/global_BorderWidth_sm'; |
patternfly-react/packages/react-core/src/components/DataList/examples/DataListWidthModifiers.tsx
Lines 49 to 56 in 3a88c11
| const previewPlaceholder = { | |
| display: 'block', | |
| width: '100%', | |
| padding: '.25rem .5rem', | |
| color: global_Color_100.var, | |
| backgroundColor: global_BackgroundColor_200.var, | |
| border: `${global_BorderWidth_sm.var} ${global_BorderColor_100.var} solid` | |
| }; |
And anywhere previewPlaceholder is referenced
Metadata
Metadata
Assignees
Labels
Type
Projects
Status