Skip to content

Wrong Type for ThExpandType.expand.collapseAllAriaLabel #8330

@dlabrecq

Description

@dlabrecq

Describe the problem
The expand prop of ThExpandType requires collapseAllAriaLabel and currently has a type of '' instead of string.

How do you reproduce the problem?
The HCS UI uses a Th for sticky column support; however, it also needs to support expandable rows. We're using ThExpandType, but the expand props; areAllExpanded and collapseAllAriaLabel are misleading. We use this functionality to collapse the current row, but there is no "collapse all" feature here.

Expected behavior
The collapseAllAriaLabel prop should be typed as string.

I'd also like to suggest that areAllExpanded and collapseAllAriaLabel be renamed. Alternatively, Td could support sticky columns.

Is this issue blocking you?
We have to workaround the issue by casting our valid string as ''

Screenshots
Screen Shot 2022-11-04 at 10 29 08 AM

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions