fix(expandable section): update to use <Button> for toggle#10891
Merged
dlabaj merged 3 commits intopatternfly:mainfrom Sep 5, 2024
Merged
fix(expandable section): update to use <Button> for toggle#10891dlabaj merged 3 commits intopatternfly:mainfrom
dlabaj merged 3 commits intopatternfly:mainfrom
Conversation
tlabaj
requested review from
a team,
kmcfaul,
mattnolting and
wise-king-sullyman
and removed request for
a team
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Some cypress tests just need to be updated, most likely due to the expandable-section__toggle class now being a div that contains a button
tlabaj
force-pushed
the
exp_section_btn
branch
from
bfb0b0e to
e83b395
Compare
Collaborator
|
Preview: https://patternfly-react-pr-10891.surge.sh A11y report: https://patternfly-react-pr-10891-a11y.surge.sh |
thatblindgeye
approved these changes
Sep 3, 2024
kmcfaul
approved these changes
Sep 5, 2024
dlabaj
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #10878