fix(Truncate, Progress): enable truncated tooltip via keyboard

[kmcfaul]

What: Closes #11384

Progress:

• Adds a tabIndex to allow keyboard focus and an updateTooltip handler to also trigger the tooltip creation. The useEffect block is there to refocus the title text after the state updates and rerenders with the tooltip.

Truncate:

• Addes a tabIndex to the subparent to allow keyboard focus
• Updates Tooltip to remove wrapping contents div & updates parentElement logic to account for the removal

[patternfly-build]

Preview: https://patternfly-react-pr-11731.surge.sh

A11y report: https://patternfly-react-pr-11731-a11y.surge.sh

[thatblindgeye]

Looks good. Unless you want to take a stab at it testing can be handled as part of the unit test revamp epic. Only nit is the handler naming being onFocus for both mouse enter and focus, but something like onFocusAndMouseEnter may be bit much.

[thatblindgeye]

Forgot the original issue is for Truncate and Progress. Can you add similar logic for the Truncate component, or we can open a followup for that since we should add tests for that more immediately

[kmcfaul]

Ah I misread the original issue, will update to add Truncate

[kmcfaul]

Instead of onFocus would something like checkTruncate or another purpose-driven rather than trigger-driven name work better?

[thatblindgeye]

Ah I misread the original issue, will update to add Truncate

At least you weren't the one to write the issue and also misread 😆

And 👍🏼 to the rename

[kmcfaul]

Updated. As far as testing, what do you think is the best approach for testing this out? The Truncate tests are mocked out such that the tooltip is always rendered so I'm a little confused on how to check that the tooltip isn't visible by default or with large parent widths / changes state on resize or trigger

[thatblindgeye]

We could probably get away with trying to test for 1) tabindex not ebing set by default and 2) tabindex being set when truncate is intended to occur. Otherwise an integration test might be the next best way and just checking the tooltip is triggered and the content can be focused

[thatblindgeye]

For real this time

[rebeccaalpert]

Looks beautiful!

[rebeccaalpert]

One of the snapshots is not happy!

[nicolethoen]

Looks like snapshots need to be regenerated

[kmcfaul]

cc @rebeccaalpert @nicolethoen Updated the snapshot from the rebase, should be good to go once it builds

[patternfly-build]

Your changes have been released in:

• @patternfly/[email protected]
• @patternfly/[email protected]
• @patternfly/[email protected]
• @patternfly/[email protected]
• @patternfly/[email protected]
• [email protected]
• @patternfly/[email protected]
• @patternfly/[email protected]

Thanks for your contribution! 🎉