Alert: Add plain variant, add expandable inline

[CooperRedhat]

What: Closes #6164, #5820

[patternfly-build]

PF4 preview: https://patternfly-react-pr-6236.surge.sh

[mcarrano]

This looks good @CooperRedhat except that I don't think we want plain variations with body text, actions, etc. The plain variant should only have the icon and title. @mcoker @mceledonia can you confirm that's what we earlier decided? That would mean these variants should be removed: https://patternfly-react-pr-6236.surge.sh/components/alert#inline-plain-variations

[mcoker]

@mcarrano from the core plain alert issue, it just says:

Unlike the full inline alert, it would not have other actions associated with it. See https://marvelapp.com/prototype/852jaj9/screen/75866265 for an example of what appearance and placement might look like.

So it says to exclude actions, but doesn't call out descriptions specifically. I think we built the examples based off of the designs, which do not include a description.

[mcoker]

Other than @mcarrano's question about the inline examples and @nicolethoen's feedback about the expandable toggle aria-label, lgtm!!

[mcarrano]

So it says to exclude actions, but doesn't call out descriptions specifically. I think we built the examples based off of the designs, which do not include a description.

I think that we definitely should remove actions from the examples, including the close/dismiss action. I guess we hadn't really considered the description but I think it could be useful to have a plain alert with a description. What do you think @mcoker @mceledonia ?

[jessiehuff]

I agree with Nicole's comments, but otherwise it looks good! I tested in VO, JAWS, and NVDA, and all seem to be able to navigate and understand everything in the alert. I do worry about future variations/uses of expandable alerts (like Nicole mentions), but these examples look great!

[CooperRedhat]

So it says to exclude actions, but doesn't call out descriptions specifically. I think we built the examples based off of the designs, which do not include a description.

I think that we definitely should remove actions from the examples, including the close/dismiss action. I guess we hadn't really considered the description but I think it could be useful to have a plain alert with a description. What do you think @mcoker @mceledonia ?

I removed the actions from inline plain examples, let me know if it looks good, thanks! @mcarrano

[mcarrano]

This looks good. Thanks for making the updates @CooperRedhat !

[tlabaj]

Looks like you need to update your snapshots, otherwise it looks good!

[patternfly-build]

Your changes have been released in:

• @patternfly/react-catalog-view-extension@4.12.62
• @patternfly/react-code-editor@4.3.49
• @patternfly/react-console@4.11.30
• @patternfly/react-core@4.154.1
• @patternfly/react-docs@5.21.28
• @patternfly/react-inline-edit-extension@4.7.72
• demo-app-ts@4.119.1
• @patternfly/react-integration@4.120.1
• @patternfly/react-log-viewer@4.6.2
• @patternfly/react-table@4.29.65
• @patternfly/react-topology@4.9.68
• @patternfly/react-virtualized-extension@4.9.37

Thanks for your contribution! 🎉