fix(datepicker): updated date picker microcopy#6263
Merged
redallen merged 4 commits intopatternfly:mainfrom Sep 9, 2021
Merged
fix(datepicker): updated date picker microcopy#6263redallen merged 4 commits intopatternfly:mainfrom
redallen merged 4 commits intopatternfly:mainfrom
Conversation
Contributor
|
If we want to change the placeholder across the board I think we should change the prop's default in Then you'd just have to adjust the |
Collaborator
|
PF4 preview: https://patternfly-react-pr-6263.surge.sh |
redallen
approved these changes
Sep 8, 2021
nicolethoen
approved these changes
Sep 9, 2021
abigaeljamie
reviewed
Sep 9, 2021
Collaborator
abigaeljamie
left a comment
abigaeljamie
left a comment
There was a problem hiding this comment.
Thank you! Looks great :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #6199
Follow up to #6196
Per discussion with @abigaeljamie, this PR capitalizes the placeholder text for date picker examples and replaces slashes in American format example with dashes (03-05-2020 vs 03/05/2020).