Skip to content

feat(SearchInput): Autocomplete SearchInput demo#6305

Merged
tlabaj merged 2 commits intopatternfly:mainfrom
nicolethoen:search_input_autocomplete
Sep 14, 2021
Merged

feat(SearchInput): Autocomplete SearchInput demo#6305
tlabaj merged 2 commits intopatternfly:mainfrom
nicolethoen:search_input_autocomplete

Conversation

@nicolethoen
Copy link
Contributor

Closes: #6210

Adds new react-demo for autocomplete

@patternfly-build
Copy link
Collaborator

patternfly-build commented Sep 13, 2021

PF4 preview: https://patternfly-react-pr-6305.surge.sh

mcoker
mcoker previously approved these changes Sep 13, 2021
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CooperRedhat
CooperRedhat previously approved these changes Sep 13, 2021
Copy link
Contributor

@CooperRedhat CooperRedhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kmcfaul
kmcfaul previously approved these changes Sep 13, 2021
mcarrano
mcarrano previously approved these changes Sep 13, 2021
Copy link
Member

@mcarrano mcarrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @nicolethoen !

Copy link
Contributor

@CooperRedhat CooperRedhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think all the comments in the demo will help consumers implement their own.

@tlabaj tlabaj merged commit 8456945 into patternfly:main Sep 14, 2021
@patternfly-build
Copy link
Collaborator

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@4.12.71
  • @patternfly/react-code-editor@4.3.58
  • @patternfly/react-console@4.11.39
  • @patternfly/react-core@4.157.0
  • @patternfly/react-docs@5.21.37
  • @patternfly/react-inline-edit-extension@4.7.81
  • demo-app-ts@4.121.0
  • @patternfly/react-integration@4.122.0
  • @patternfly/react-log-viewer@4.6.11
  • @patternfly/react-table@4.30.0
  • @patternfly/react-topology@4.9.77
  • @patternfly/react-virtualized-extension@4.9.46

Thanks for your contribution! 🎉

@nicolethoen nicolethoen deleted the search_input_autocomplete branch February 8, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add auto-complete to Search input

7 participants