Skip to content

Fix for no autocomplete for Typeahead Select #6623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 1 commit into from
Nov 19, 2021
Merged

Fix for no autocomplete for Typeahead Select #6623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/react-core/src/components/Select/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,7 +934,7 @@ export class Select extends React.Component<SelectProps & OUIAProps, SelectState
}
}}
ref={this.filterRef}
autoComplete="off"
autoComplete="never"
/>
</div>
<Divider key="inline-filter-divider" />
Expand Down Expand Up @@ -1128,7 +1128,7 @@ export class Select extends React.Component<SelectProps & OUIAProps, SelectState
type="text"
onClick={this.onClick}
onChange={this.onChange}
autoComplete="off"
autoComplete="never"
disabled={isDisabled}
ref={this.inputRef}
/>
Expand All @@ -1152,7 +1152,7 @@ export class Select extends React.Component<SelectProps & OUIAProps, SelectState
type="text"
onChange={this.onChange}
onClick={this.onClick}
autoComplete="off"
autoComplete="never"
disabled={isDisabled}
ref={this.inputRef}
/>
Expand Down
48 changes: 24 additions & 24 deletions packages/react-core/src/components/Select/__tests__/__snapshots__/Select.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2831,7 +2831,7 @@ exports[`checkbox select renders expanded with filtering successfully 1`] = `
class="pf-c-select__menu-search"
>
<input
autocomplete="off"
autocomplete="never"
class="pf-c-form-control pf-m-search"
type="search"
/>
Expand Down Expand Up @@ -2956,7 +2956,7 @@ exports[`checkbox select renders expanded with filtering successfully 1`] = `
class="pf-c-select__menu-search"
>
<input
autocomplete="off"
autocomplete="never"
class="pf-c-form-control pf-m-search"
type="search"
/>
Expand Down Expand Up @@ -3122,7 +3122,7 @@ exports[`checkbox select renders expanded with filtering successfully 1`] = `
class="pf-c-select__menu-search"
>
<input
autocomplete="off"
autocomplete="never"
class="pf-c-form-control pf-m-search"
type="search"
/>
Expand Down Expand Up @@ -3214,7 +3214,7 @@ exports[`checkbox select renders expanded with filtering successfully 1`] = `
key="inline-filter"
>
<input
autoComplete="off"
autoComplete="never"
className="pf-c-form-control pf-m-search"
key="inline-filter-input"
onChange={[Function]}
Expand Down Expand Up @@ -3485,7 +3485,7 @@ exports[`checkbox select renders expanded with filtering successfully 2`] = `
class="pf-c-select__menu-search"
>
<input
autocomplete="off"
autocomplete="never"
class="pf-c-form-control pf-m-search"
type="search"
/>
Expand Down Expand Up @@ -3610,7 +3610,7 @@ exports[`checkbox select renders expanded with filtering successfully 2`] = `
class="pf-c-select__menu-search"
>
<input
autocomplete="off"
autocomplete="never"
class="pf-c-form-control pf-m-search"
type="search"
/>
Expand Down Expand Up @@ -3776,7 +3776,7 @@ exports[`checkbox select renders expanded with filtering successfully 2`] = `
class="pf-c-select__menu-search"
>
<input
autocomplete="off"
autocomplete="never"
class="pf-c-form-control pf-m-search"
type="search"
/>
Expand Down Expand Up @@ -3868,7 +3868,7 @@ exports[`checkbox select renders expanded with filtering successfully 2`] = `
key="inline-filter"
>
<input
autoComplete="off"
autoComplete="never"
className="pf-c-form-control pf-m-search"
key="inline-filter-input"
onChange={[Function]}
Expand Down Expand Up @@ -6002,7 +6002,7 @@ exports[`select custom select filter filters properly 1`] = `
>
<input
aria-label=""
autocomplete="off"
autocomplete="never"
class="pf-c-form-control pf-c-select__toggle-typeahead"
id="custom-select-filters-select-typeahead"
placeholder=""
Expand Down Expand Up @@ -6098,7 +6098,7 @@ exports[`select custom select filter filters properly 1`] = `
<input
aria-activedescendant={null}
aria-label=""
autoComplete="off"
autoComplete="never"
className="pf-c-form-control pf-c-select__toggle-typeahead"
disabled={false}
id="custom-select-filters-select-typeahead"
Expand Down Expand Up @@ -9595,7 +9595,7 @@ exports[`typeahead multi select renders closed successfully 1`] = `
<input
aria-invalid="false"
aria-label=""
autocomplete="off"
autocomplete="never"
class="pf-c-form-control pf-c-select__toggle-typeahead"
id="typeahead-multi-select-closed-select-multi-typeahead-typeahead"
placeholder=""
Expand Down Expand Up @@ -9647,7 +9647,7 @@ exports[`typeahead multi select renders closed successfully 1`] = `
aria-activedescendant={null}
aria-invalid={false}
aria-label=""
autoComplete="off"
autoComplete="never"
className="pf-c-form-control pf-c-select__toggle-typeahead"
disabled={false}
id="typeahead-multi-select-closed-select-multi-typeahead-typeahead"
Expand Down Expand Up @@ -9856,7 +9856,7 @@ exports[`typeahead multi select renders expanded successfully 1`] = `
<input
aria-invalid="false"
aria-label=""
autocomplete="off"
autocomplete="never"
class="pf-c-form-control pf-c-select__toggle-typeahead"
id="pf-select-toggle-id-13-select-multi-typeahead-typeahead"
placeholder=""
Expand Down Expand Up @@ -9966,7 +9966,7 @@ exports[`typeahead multi select renders expanded successfully 1`] = `
aria-activedescendant={null}
aria-invalid={false}
aria-label=""
autoComplete="off"
autoComplete="never"
className="pf-c-form-control pf-c-select__toggle-typeahead"
disabled={false}
id="pf-select-toggle-id-13-select-multi-typeahead-typeahead"
Expand Down Expand Up @@ -10585,7 +10585,7 @@ exports[`typeahead multi select renders selected successfully 1`] = `
<input
aria-invalid="false"
aria-label=""
autocomplete="off"
autocomplete="never"
class="pf-c-form-control pf-c-select__toggle-typeahead"
id="typeahead-multi-select-selected-select-multi-typeahead-typeahead"
placeholder=""
Expand Down Expand Up @@ -10949,7 +10949,7 @@ exports[`typeahead multi select renders selected successfully 1`] = `
aria-activedescendant={null}
aria-invalid={false}
aria-label=""
autoComplete="off"
autoComplete="never"
className="pf-c-form-control pf-c-select__toggle-typeahead"
disabled={false}
id="typeahead-multi-select-selected-select-multi-typeahead-typeahead"
Expand Down Expand Up @@ -11472,7 +11472,7 @@ exports[`typeahead select renders closed successfully 1`] = `
>
<input
aria-label=""
autocomplete="off"
autocomplete="never"
class="pf-c-form-control pf-c-select__toggle-typeahead"
id="typeahead-select-closed-select-typeahead"
placeholder=""
Expand Down Expand Up @@ -11523,7 +11523,7 @@ exports[`typeahead select renders closed successfully 1`] = `
<input
aria-activedescendant={null}
aria-label=""
autoComplete="off"
autoComplete="never"
className="pf-c-form-control pf-c-select__toggle-typeahead"
disabled={false}
id="typeahead-select-closed-select-typeahead"
Expand Down Expand Up @@ -11731,7 +11731,7 @@ exports[`typeahead select renders expanded successfully 1`] = `
>
<input
aria-label=""
autocomplete="off"
autocomplete="never"
class="pf-c-form-control pf-c-select__toggle-typeahead"
id="pf-select-toggle-id-8-select-typeahead"
placeholder=""
Expand Down Expand Up @@ -11840,7 +11840,7 @@ exports[`typeahead select renders expanded successfully 1`] = `
<input
aria-activedescendant={null}
aria-label=""
autoComplete="off"
autoComplete="never"
className="pf-c-form-control pf-c-select__toggle-typeahead"
disabled={false}
id="pf-select-toggle-id-8-select-typeahead"
Expand Down Expand Up @@ -12333,7 +12333,7 @@ exports[`typeahead select renders selected successfully 1`] = `
>
<input
aria-label=""
autocomplete="off"
autocomplete="never"
class="pf-c-form-control pf-c-select__toggle-typeahead"
id="pf-select-toggle-id-9-select-typeahead"
placeholder=""
Expand Down Expand Up @@ -12460,7 +12460,7 @@ exports[`typeahead select renders selected successfully 1`] = `
<input
aria-activedescendant={null}
aria-label=""
autoComplete="off"
autoComplete="never"
className="pf-c-form-control pf-c-select__toggle-typeahead"
disabled={false}
id="pf-select-toggle-id-9-select-typeahead"
Expand Down Expand Up @@ -12943,7 +12943,7 @@ exports[`typeahead select test select existing option on a non-creatable select
>
<input
aria-label=""
autocomplete="off"
autocomplete="never"
class="pf-c-form-control pf-c-select__toggle-typeahead"
id="pf-select-toggle-id-12-select-typeahead"
placeholder=""
Expand Down Expand Up @@ -13013,7 +13013,7 @@ exports[`typeahead select test select existing option on a non-creatable select
<input
aria-activedescendant={null}
aria-label=""
autoComplete="off"
autoComplete="never"
className="pf-c-form-control pf-c-select__toggle-typeahead"
disabled={false}
id="pf-select-toggle-id-12-select-typeahead"
Expand Down