Skip to content

chore(Tabs): Tabs table demo #6692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 7 commits into from
Jan 6, 2022
Merged

chore(Tabs): Tabs table demo #6692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aeb2544
chore(Tabs): Added tabs with table demo, wip
gabipodolnikova Nov 30, 2021
5c27b7a
Adds drawer panel content
gabipodolnikova Dec 2, 2021
217031a
chore(Tabs): TabsAndTable demo form js to ts
gabipodolnikova Dec 10, 2021
9c533da
updates test snapshot
gabipodolnikova Dec 20, 2021
98b7ab6
fixes the failing docs build
gabipodolnikova Dec 20, 2021
9d7b54c
removing forgotten line in config
gabipodolnikova Dec 21, 2021
d1a5972
Review css fixes
gabipodolnikova Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/react-core/src/components/Tabs/__tests__/Tabs.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,15 +195,15 @@ test('should render secondary tabs', () => {
<Tab id="secondary tab1" eventKey={10} title={<TabTitleText>"Secondary Tab item 1"</TabTitleText>}>
Secondary Tab 1 section
</Tab>
<Tab id="secondary tab2" eventKey={11} title={<TabTitleText>"Secondary Tab item 2"</TabTitleText>}>>
<Tab id="secondary tab2" eventKey={11} title={<TabTitleText>"Secondary Tab item 2"</TabTitleText>}>
Secondary Tab 2 section
</Tab>
<Tab id="secondary tab3" eventKey={12} title={<TabTitleText>"Secondary Tab item 3"</TabTitleText>}>>
<Tab id="secondary tab3" eventKey={12} title={<TabTitleText>"Secondary Tab item 3"</TabTitleText>}>
Secondary Tab 3 section
</Tab>
</Tabs>
</Tab>
<Tab id="tab2" eventKey={1} title={<TabTitleText>"Tab item 2"</TabTitleText>}>>
<Tab id="tab2" eventKey={1} title={<TabTitleText>"Tab item 2"</TabTitleText>}>
Tab 2 section
</Tab>
<Tab id="tab3" eventKey={2} title={<TabTitleText>"Tab item 3"</TabTitleText>}>
Expand Down
6 changes: 3 additions & 3 deletions packages/react-core/src/components/Tabs/__tests__/__snapshots__/Tabs.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,7 +1077,7 @@ Array [
role="tabpanel"
tabindex="0"
>
&gt; Secondary Tab 2 section
Secondary Tab 2 section
</section>
<section
aria-labelledby="pf-tab-12-secondary tab3"
Expand All @@ -1089,7 +1089,7 @@ Array [
role="tabpanel"
tabindex="0"
>
&gt; Secondary Tab 3 section
Secondary Tab 3 section
</section>
</section>,
<section
Expand All @@ -1102,7 +1102,7 @@ Array [
role="tabpanel"
tabindex="0"
>
&gt; Tab 2 section
Tab 2 section
</section>,
<section
aria-labelledby="pf-tab-2-tab3"
Expand Down
11 changes: 10 additions & 1 deletion packages/react-core/src/demos/Tabs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ section: components
import DashboardWrapper from './examples/DashboardWrapper';
import CheckCircleIcon from '@patternfly/react-icons/dist/js/icons/check-circle-icon';
import InfoCircleIcon from '@patternfly/react-icons/dist/js/icons/info-circle-icon';
import CodeIcon from '@patternfly/react-icons/dist/esm/icons/code-icon';
import CodeBranchIcon from '@patternfly/react-icons/dist/esm/icons/code-branch-icon';
import CubeIcon from '@patternfly/react-icons/dist/esm/icons/cube-icon';
import FilterIcon from '@patternfly/react-icons/dist/esm/icons/filter-icon';
import SortAmountDownIcon from '@patternfly/react-icons/dist/esm/icons/sort-amount-down-icon';

## Demos

Expand Down Expand Up @@ -440,4 +445,8 @@ TabsOpenWithSecondaryTabsDemo = () => {

### Nested tabs
```js isFullscreen file="./Tabs/NestedTabsDemo.js"
```
```

### Tables and tabs
```js isFullscreen file="./examples/Tabs/TabsAndTable.tsx"
Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman Dec 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```js isFullscreen file="./examples/Tabs/TabsAndTable.tsx"
```ts isFullscreen file="./examples/Tabs/TabsAndTable.tsx"

Copy link
Contributor Author

@gabipodolnikova gabipodolnikova Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said in the PR description, it is not possible with the current config to import it like you suggested... :(

```
Loading