Skip to content

fix(Tabs): allow href navigation from tabs#6755

Merged
jpuzz0 merged 1 commit intopatternfly:mainfrom
jonkoops:fix/tabs-href
Jan 10, 2022
Merged

fix(Tabs): allow href navigation from tabs#6755
jpuzz0 merged 1 commit intopatternfly:mainfrom
jonkoops:fix/tabs-href

Conversation

@jonkoops
Copy link
Contributor

Closes #6533

@patternfly-build
Copy link
Collaborator

@jpuzz0 jpuzz0 self-requested a review January 10, 2022 17:11
Copy link
Contributor

@jpuzz0 jpuzz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke in Slack about this. Although this does introduce an problem with the Patternfly nav examples not being focused, it does seem to be specific to our environment and therefore a separate issue.

@jpuzz0 jpuzz0 merged commit 290d89a into patternfly:main Jan 10, 2022
@patternfly-build
Copy link
Collaborator

Your changes have been released in:

  • eslint-plugin-patternfly-react@4.22.10
  • @patternfly/react-catalog-view-extension@4.34.10
  • @patternfly/react-charts@6.36.10
  • @patternfly/react-code-editor@4.24.10
  • @patternfly/react-console@4.34.10
  • @patternfly/react-core@4.183.10
  • @patternfly/react-docs@5.44.10
  • @patternfly/react-icons@4.34.10
  • @patternfly/react-inline-edit-extension@4.28.10
  • demo-app-ts@4.143.10
  • @patternfly/react-integration@4.145.10
  • @patternfly/react-log-viewer@4.28.10
  • @patternfly/react-styles@4.33.10
  • @patternfly/react-table@4.52.10
  • @patternfly/react-tokens@4.35.10
  • @patternfly/react-topology@4.30.10
  • @patternfly/react-virtualized-extension@4.30.10
  • transformer-cjs-imports@4.21.10

Thanks for your contribution! 🎉

@jonkoops jonkoops deleted the fix/tabs-href branch January 10, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabs href prop doesn't work

4 participants