docs(Tabs): add gray tabs demo (patternfly#6810)#6811
docs(Tabs): add gray tabs demo (patternfly#6810)#6811tlabaj merged 7 commits intopatternfly:mainfrom
Conversation
nicolethoen
requested review from
mcarrano,
mcoker,
nicolethoen and
wise-king-sullyman
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
This looks really good! There are some deviations from the core demo, but in at least some cases, I'd like to update the core demo to match this one. Left some comments for review.
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
Just one thing about the heading levels! #6811 (comment)
gitdallas
force-pushed
the
gray-tab-demo
branch
2 times, most recently
from
22062bc to
01348f0
Compare
gitdallas
force-pushed
the
gray-tab-demo
branch
from
01348f0 to
2f3b3e5
Compare
|
LGTM! Only thing is the preview box is just a big question mark on my end? Not sure if that's normal/if it'll get resolved when pushed but thought i'd flag haha
|
@nicolethoen mentioned something to me about this. i think several get added at a time later? lmk if this is something that i should be adding. |
|
Yep! The screenshots/previews of full page demos will be generated as part of the release process. It tends to be easier to do them all at once at the end of each milestone. |
8 participants
What: Closes #6810
Additional issues: