feat(Masthead, PageHeader): update component logic#8655
Merged
tlabaj merged 3 commits intopatternfly:v5from Feb 10, 2023
Merged
feat(Masthead, PageHeader): update component logic#8655tlabaj merged 3 commits intopatternfly:v5from
tlabaj merged 3 commits intopatternfly:v5from
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-8655.surge.sh A11y report: https://patternfly-react-pr-8655-a11y.surge.sh |
thatblindgeye
approved these changes
Feb 6, 2023
nicolethoen
reviewed
Feb 7, 2023
Contributor
There was a problem hiding this comment.
we likely need a codemod to either warn about this update to the default component type in these cases, or just update the component passed to 'a' to prevent breaking changes? Would you mind at least opening the code mod issue to track that (or double check that one already exist and link it here?)
Contributor
Author
|
@nicolethoen Opened patternfly/pf-codemods#242 |
gitdallas
approved these changes
Feb 7, 2023
mcoker
reviewed
Feb 9, 2023
Contributor
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
lgtm! Just a couple of comments.
kmcfaul
force-pushed
the
masthead-element
branch
from
b22ce67 to
55e1bf4
Compare
tlabaj
approved these changes
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #4665
Adds logic to component type of Masthead and PageHeader. If an
hrefis passed, the component type will be an anchor. If anonClickis passed, the type will be a button. Otherwise the type will be a span.