fix(react-core): updated class names to include versions#9174
fix(react-core): updated class names to include versions#9174tlabaj merged 3 commits intopatternfly:v5from
Conversation
|
Preview: https://patternfly-react-pr-9174.surge.sh A11y report: https://patternfly-react-pr-9174-a11y.surge.sh |
| id: About modal | ||
| section: components | ||
| cssPrefix: pf-c-about-modal-box | ||
| cssPrefix: pf-v5-c-about-modal-box |
There was a problem hiding this comment.
Do we want to update this in example files right now? Looks like the CSS variables tables in component pages is empty in the preview. cc @nicolethoen would this be tied to patternfly/patternfly-org#3489 ?
There was a problem hiding this comment.
Yeah I think that with patternfly/patternfly-org#3489 the tables will work with this change.
There was a problem hiding this comment.
agreed! I think to keep parity with core, we should use the versioned prefixes here. My org work will get all this working again once it merges and I finish the follow up work in react to pull in the newer doc-framework version
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
LGTM, one small comment that isn't a blocker.
| <div className="pf-v5-l-flex__item">100C</div> | ||
| <div className="pf-v5-l-flex__item">50C</div> | ||
| <div className="pf-v5-l-flex__item">0C</div> |
There was a problem hiding this comment.
Could you use <FlexItem> here and the other places in this file?
| <div className="pf-v5-l-flex__item">100C</div> | |
| <div className="pf-v5-l-flex__item">50C</div> | |
| <div className="pf-v5-l-flex__item">0C</div> | |
| <FlexItem>100C</FlexItem> | |
| <FlexItem>50C</FlexItem> | |
| <FlexItem>0C</FlexItem> |
There was a problem hiding this comment.
Pushed a change that I think addressed this, look good to you?
…9174) * fix(react-core): updated class names to include versions * fix(react-core): updated pf-l- class names to include versions * chore(CardDemos): changed flex item styled div to FlexItem components
7 participants
What: Closes #9144
Additional issues: