fix(Pagination): remove spin buttons#9219
Conversation
|
Preview: https://patternfly-react-pr-9219.surge.sh A11y report: https://patternfly-react-pr-9219-a11y.surge.sh |
mcarrano
left a comment
mcarrano
left a comment
There was a problem hiding this comment.
Looks good. Thanks @adamviktora !
There was a problem hiding this comment.
This fixes the base styling, but it's worth noting that if this does not use <TextInput>, all changes to the core form control component will need to be maintained here separately.
For example, another thing that isn't working properly in this PR is the disabled styling, because the visual presentation for a disabled form control changed with v5 (the styles.formControl div also needs the class pf-m-disabled). You can see in v4 that the no items and one page example example inputs are disabled and they are not disabled in this PR build.
If we can't use <TextInput> here for some reason, it would be good to review this a little more to make sure there is full parity with the form control component.
| <div className={styles.paginationNavPageSelect}> | ||
| <input | ||
| className={css(styles.formControl)} | ||
| <TextInput |
* fix(Pagination): remove spin buttons * fix(Pagination): update snapshots and integration tests * use TextInput instead of input, change page type from deprecated type --------- Co-authored-by: Titani <tlabaj@redaht.com>
7 participants
What: Closes #9218, #9187