Skip to content

fix(expandable-section): use link button, update styles#7000

Merged
mcoker merged 1 commit intopatternfly:v6from
mcoker:issue-6998
Aug 22, 2024
Merged

fix(expandable-section): use link button, update styles#7000
mcoker merged 1 commit intopatternfly:v6from
mcoker:issue-6998

Conversation

@mcoker
Copy link
Contributor

@mcoker mcoker commented Aug 22, 2024

fixes #6998

Visual regression report - expandable-section.pdf

Just a draft to see if it's something we want to get in this sprint. Cleans up some styles, too.

The react changes would be:

  • Make __toggle a <div> instead of a custom button
  • Use a link <Button> in __toggle and update old __toggle logic to apply to the <Button> instead

@mcoker mcoker requested a review from lboehling August 22, 2024 01:43
@patternfly-build
Copy link
Collaborator

patternfly-build commented Aug 22, 2024

Copy link

@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!! ✨

@mcoker mcoker marked this pull request as ready for review August 22, 2024 20:34
Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love removing extra styling :)

@mcoker
Copy link
Contributor Author

mcoker commented Aug 22, 2024

@tlabaj before we commit this in core, are you OK with this change and the react follow-up needed? TL;DR

  • I reviewed expandable section with Lucia and we noted some visual discrepancies with the original design intent, so I made this PR as a spike to see what the lift is to align with the design intent. I'm good with it going in on the core side, it was a simple update.
  • I think the react update is to
    • Remove expandable section's custom toggle and replace it with a link <Button>
    • Move the logic that was on the custom toggle to the <Button> (here's the core component logic on button)
    • Add a <div class="pf-v6-c-expandable-section__toggle> wrapper around the button.

@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 6.0.0-alpha.223 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants