fix(expandable-section): use link button, update styles#7000
Merged
mcoker merged 1 commit intopatternfly:v6from Aug 22, 2024
Merged
fix(expandable-section): use link button, update styles#7000mcoker merged 1 commit intopatternfly:v6from
mcoker merged 1 commit intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-pr-7000.surge.sh A11y report: https://patternfly-pr-7000-a11y.surge.sh |
srambach
approved these changes
Aug 22, 2024
Member
srambach
left a comment
There was a problem hiding this comment.
Love removing extra styling :)
Contributor
Author
|
@tlabaj before we commit this in core, are you OK with this change and the react follow-up needed? TL;DR
|
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.223 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6998
Visual regression report - expandable-section.pdf
Just a draft to see if it's something we want to get in this sprint. Cleans up some styles, too.
The react changes would be:
__togglea<div>instead of a custom button<Button>in__toggleand update old__togglelogic to apply to the<Button>instead