feat(853): favorite button codemod#854
Merged
gitdallas merged 1 commit intopatternfly:mainfrom Aug 15, 2025
Merged
Conversation
gitdallas
requested review from
jenny-s51,
thatblindgeye and
wise-king-sullyman
gitdallas
force-pushed
the
feat/favorite-button-codemod
branch
from
82f52b3 to
088e9cf
Compare
jenny-s51
suggested changes
Aug 12, 2025
Contributor
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Thanks @gitdallas ! Tested this locally and this is looking great - left some comments below.
...f-codemods/src/rules/v6/buttonSupportFavoriteVariant/button-support-favorite-variant.test.ts
Show resolved
Hide resolved
...f-codemods/src/rules/v6/buttonSupportFavoriteVariant/button-support-favorite-variant.test.ts
Outdated
Show resolved
Hide resolved
gitdallas
force-pushed
the
feat/favorite-button-codemod
branch
from
088e9cf to
4ac3e9f
Compare
jenny-s51
approved these changes
Aug 13, 2025
Contributor
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Thanks @gitdallas , LGTM
wise-king-sullyman
approved these changes
Aug 14, 2025
...f-codemods/src/rules/v6/buttonSupportFavoriteVariant/button-support-favorite-variant.test.ts
Show resolved
Hide resolved
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
gitdallas
force-pushed
the
feat/favorite-button-codemod
branch
from
4ac3e9f to
3f12591
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #853