Open
Conversation
Contributor
|
Have you tried passing |
Author
|
sure, that was the first thing I tried
|
|
Hi guys, do you need any help with this PR? It would be great to have |
Author
|
yes, I need @tomegz to check why the tests are failed and approve this PR |
|
+1 |
Contributor
|
You should first resolve the conflicts and make your branch up to date. Maybe the tests will stop failing then. Also, looking through the code it seems really weird that it doesn't work for you if you pass it like this: |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to make some actions in my app on every input focus, so could you pls add the "onFocus" handler? Thanks!