Skip to content

build: replaces node-sass with sass#381

Merged
mcataford merged 2 commits intomasterfrom
build/node-sass-deprecation
Aug 4, 2021
Merged

build: replaces node-sass with sass#381
mcataford merged 2 commits intomasterfrom
build/node-sass-deprecation

Conversation

@mcataford
Copy link
Collaborator

Description

node-sass is now deprecated and the suggested replacement is dart-sass. This substitutes one for the other. Major pro for this: node-sass did some heavy node-gyp building whereas this doesn't, making building-from-scratch way faster.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have used ESLint & Prettier to follow the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcataford mcataford marked this pull request as ready for review August 4, 2021 02:16
@mcataford
Copy link
Collaborator Author

QA: diff'ed CSS output before and after the change, they are functionally the same. sass seems to insert a handful of extra newlines, but otherwise, same stylesheet. 👍

@mcataford mcataford merged commit b7ed582 into master Aug 4, 2021
@mcataford mcataford deleted the build/node-sass-deprecation branch August 4, 2021 02:17
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

🎉 This PR is included in version 8.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
* build: replaces node-sass with sass

* chore: config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant