Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds type definition modules so that React TypeScript projects using this library do not need to introduce a drop-in module augmentation of their own, such as in this example gist.
Resolves #346.
Description
.d.tsmodules for all.jsfiles exported by this library..d.tsmodules..ts(x)tests insrc/components/__tests__alongside the existing.jstests.README.md.lintsupport for the TypeScript modules.Demo:
Locally via
yalcyalcglobally.react-intl-tel-inputfor local-only publishing.yarn build yalc publish --no-scripts # skips prebuild to unblock youreact-intl-tel-inputpackage.react-intl-tel-inputin the React app:App.tsxIntlTelInputto see its TypeScript definitions.Remotely via CodeSandbox
A live preview is available with a pre-merge variant of this library:
@andrewsantarin/react-intl-tel-input.Note: The pre-merge variant is somewhat behind in CI changes from
master, but the module type definitions are still up to date.Types of changes
Checklist: