Skip to content

Upgrade to hishel 2 - #3996

Open
pgjones wants to merge 1 commit into
pdm-project:mainfrom
pgjones:hishel
Open

pgjones wants to merge 1 commit into
pdm-project:mainfrom
pgjones:hishel

Conversation

@pgjones

@pgjones pgjones commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

This requires renaming SyncSqliteStorage to SqliteStorage and then a pdm lock to update.

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@human-attestation

Copy link
Copy Markdown

🛡️ Human Attestation required. A human needs to confirm this PR once before it can merge.

Attest this PR — sign in with GitHub, pass the challenge, and confirm one of the statements.

@pgjones pgjones mentioned this pull request Nov 5, 2026
1 task done
@pgjones

pgjones commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor Author

The attestation bot permissions seem quite broad...
I've contributed before and this PR does not contain AI generated code.

@pgjones
pgjones force-pushed the hishel branch 3 times, most recently from 551d8d4 to 55cc13c Compare November 5, 2026 15:21
@codecov

codecov Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.49%. Comparing base (c236245) to head (4366b1d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/models/session.py 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3996      +/-   ##
==========================================
+ Coverage   89.46%   89.49%   +0.03%     
==========================================
  Files         120      120              
  Lines       13625    13626       +1     
  Branches     2336     2337       +1     
==========================================
+ Hits        12190    12195       +5     
+ Misses        896      892       -4     
  Partials      539      539              
Flag Coverage Δ
unittests 89.38% <90.90%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This requires renaming SyncSqliteStorage to SqliteStorage and then a
pdm lock to update.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant