Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.
This repository was archived by the owner on Sep 2, 2022. It is now read-only.

Suggestion, BBands MA argument should be enforced to be a supported type (Series or None) #133

@fredrik-corneliusson

Description

@fredrik-corneliusson

BBands MA argument is silently ignored if it is not a pd.Series.
As the fool that I am I gave an integer as MA argument instead of a pd.Series and did not notice my mistake immediately.
What I expected: If it is not a supported type an error should be raised or a warning should be printed.
Example:

from finta import TA
# MA argument is not correct type and will be ignored
bbands = TA.BBANDS(df, 20, MA=50)

This was in Fintra 1.3

Thanks for a fantastic library!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions