libpostal: discard parse containing single "suburb" label#1627
Open
missinglink wants to merge 1 commit intomasterfrom
Open
libpostal: discard parse containing single "suburb" label#1627missinglink wants to merge 1 commit intomasterfrom
missinglink wants to merge 1 commit intomasterfrom
Conversation
4a7ecf6 to
ea065bb
Compare
ea065bb to
293ef5c
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


It seems that
libpostalgets confused with airports, returning the labelsuburb:However it returns the correct label for a
neighbourhood:And also in the case where the text refers to either an airport or a neighbourhood:
I think the best course of action here is to check for any parse containing a single label of type "suburb" and then discarding it.
While this certainly will discard some valid neighbourhood parses, they should be adequately handled by the fallback parsing.