Docker: Egg check-updates does not run automatically

[TinyMemoria]

Current Behavior

Eggs are not automatically checked for updates.
Maually running php /var/www/html/artisan p:egg:check-updates inside the container is successful.
Running supervisorctl status inside the container shows:

caddy RUNNING pid 54, uptime 0:32:11
php-fpm RUNNING pid 55, uptime 0:32:11
queue-worker RUNNING pid 56, uptime 0:32:11
supercronic` RUNNING pid 57, uptime 0:32:11

Running cat /etc/crontabs/crontab inside the container shows:

* * * * * php /var/www/html/artisan schedule:run

As an interim workaround i have appended the following to the mentioned crontab file:

0 0 * * * php /var/www/html/artisan p:egg:check-updates

Which gives the desired behavior.

Expected Behavior

I expect the eggs to be checked for updates at any interval.

Steps to Reproduce

Docker setup guide;
I installed panel fresh with beta 30 approximately 2 months ago.
Updated to beta 31 when available.
Skipped the beta 32 update.
Updated to beta 33 21st FEB.

Noted eggs should be checked for updates regularly due to a recent discord discussion with Boy123 commenting "It should normally auto check. If it doesn't for you there is a chance your queue worker and/or crontab isn't setup"

Noticed my eggs hadn't been auto checking for updates.

Panel Version

v1.0.0-beta33

Wings Version

v1.0.0-beta24

Games and/or Eggs Affected

No response

Docker Image

No response

Error Logs

Is there an existing issue for this?

• I have searched the existing issues before opening this issue.
• I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server.
• I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.

[Boy132]

Will probably be fixed with #2256

[TinyMemoria]

Will probably be fixed with #2256

Can you explain how that PR fixes the issue when running p:egg:check-updates manually, is successful? I don't follow that one.

[mristau]

did you have any 404 error during the p:egg:check-updates, could be happening that an error during scheduled check will break the check. We will see if it'll work again next version

[TinyMemoria]

did you have any 404 error during the p:egg:check-updates, could be happening that an error during scheduled check will break the check. We will see if it'll work again next version

No, I did not encounter any 404 error. All the eggs I tested with had a valid update_url.
When I run the check-updates manually. All eggs with update available show as such.
No error is observed at all.

[Boy132]

php artisan schedule:run should run the update check daily:

panel/app/Console/Kernel.php

Line 46 in 593f209

$schedule->command(CheckEggUpdatesCommand::class)->daily();

I will reopen this and let @parkervcp have a look.