Open
Conversation
added 2 commits
March 9, 2025 15:40
Author
|
New to contributing, let me know if there's any issues with my MR |
Contributor
You changed the author what is not allowed. You overwrote a pelican egg with a pterodactyl egg what is not allowed |
Author
|
Ah sorry about the author, I was confused on that one and thought I had to put my email if I updated it. About the pterodactyl egg, not sure about that it looks like the old script was a pterodactyl egg and the one I exported from the Pelican panel is a Pelican egg. If you look at the original egg-forge-enhanced.json, the version says "PTDL_v2" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forge egg had URL references that were incorrect leading to curl not downloading the installer.
Fixed URL references.
Not able to fix installs for MC versions lower than 1.5.2 since Forge shipped has a zip
Added URL references for all versions though in case someone else wants to use the fixed URLs and make installs below 1.5.2 work
Checklist for all submissions