Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
==========================================
- Coverage 85.38% 85.35% -0.03%
==========================================
Files 3 3
Lines 1314 1325 +11
Branches 210 212 +2
==========================================
+ Hits 1122 1131 +9
- Misses 91 92 +1
- Partials 101 102 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
53ecbca to
96a09f2
Compare
5912157 to
082b8b4
Compare
explain.h header file was splitted in PostgreSQL 18, so import required headers for that version.
In commit 3eea7a0 ExecutorRun hook signature changed. Use new singature for PG18.
Add build workflow for PostgreSQL 18.
3925ad8 to
d6eff3b
Compare
There is no need to use unsigned values for hash ids as we cast them to signed values in SQL output anyways.
This commit address change introduced in dc68515, where SET queries noramlization rules changed.
4ebd461 to
2596fc8
Compare
This commit address changes made in commits 62d712e, c2da1a5d6, 9fbd53dea and 0f65f3e. These commits change how PG18 doing jumbling of queries that contain constants list in it.
This commit follows change made in 8928817 commit in PGSS, which in turn address changes made in 0709b7e commit in PG spinlocks.
007_settings_pgsm_query_shared_buffer.pl test expects ouptut file per major version. So add one for PostgreSQL 18. Also add expected column names for 018_column_names.pl test
Add wal_buffers_full value, same as was introduced in PGSS in commit ce5bcc4.
2596fc8 to
8fe3d4c
Compare
Closed
1 task
jeltz
approved these changes
Sep 30, 2025
Contributor
jeltz
left a comment
There was a problem hiding this comment.
Looks good. Feel free to merge.
These are the same counters as were intorduced in pg_stat_statements in commit cf54a2c.
This commet address refactoring made in PostgreSQL codebase in commit 10b7218.
3aa4837 to
f77afaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PG-1907
Description
Full PG18 diff: postgres/postgres@REL_17_STABLE...REL_18_STABLE
Notable changes:
ExecutorRun signature change: postgres/postgres@3eea7a0
Use macro to define the number of enum values: postgres/postgres@10b7218
Use int64 instead of uint64 for queryIDs: postgres/postgres@c3eda50
In SQL we always show them as signed + it's just hashes, so we can do that change for all version of PG.
Add const list squashing during query normalization:
postgres/postgres@62d712e
postgres/postgres@0f65f3e
postgres/postgres@c2da1a5
Removed volatile qualifiers, they are not needed for spinlocks since PG 9.5:
postgres/postgres@8928817
postgres/postgres@0709b7e
Add columns to track parallel worker activity :postgres/postgres@cf54a2c
Add wal_buffers_full: postgres/postgres@ce5bcc4
Links