Skip to content

Comments

PG-1907 PG-18 Support#560

Merged
artemgavrilov merged 11 commits intomainfrom
PG-1907-support-PG-18
Sep 30, 2025
Merged

PG-1907 PG-18 Support#560
artemgavrilov merged 11 commits intomainfrom
PG-1907-support-PG-18

Conversation

@artemgavrilov
Copy link
Contributor

@artemgavrilov artemgavrilov commented Sep 5, 2025

PG-1907

Description

Full PG18 diff: postgres/postgres@REL_17_STABLE...REL_18_STABLE

Notable changes:

  1. ExecutorRun signature change: postgres/postgres@3eea7a0

  2. Use macro to define the number of enum values: postgres/postgres@10b7218

  3. Use int64 instead of uint64 for queryIDs: postgres/postgres@c3eda50
    In SQL we always show them as signed + it's just hashes, so we can do that change for all version of PG.

  4. Add const list squashing during query normalization:
    postgres/postgres@62d712e
    postgres/postgres@0f65f3e
    postgres/postgres@c2da1a5

  5. Removed volatile qualifiers, they are not needed for spinlocks since PG 9.5:
    postgres/postgres@8928817
    postgres/postgres@0709b7e

  6. Add columns to track parallel worker activity :postgres/postgres@cf54a2c

  7. Add wal_buffers_full: postgres/postgres@ce5bcc4

Links

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 84.56790% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.35%. Comparing base (d74e927) to head (f77afaf).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
pg_stat_monitor.c 84.56% 11 Missing and 14 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   85.38%   85.35%   -0.03%     
==========================================
  Files           3        3              
  Lines        1314     1325      +11     
  Branches      210      212       +2     
==========================================
+ Hits         1122     1131       +9     
- Misses         91       92       +1     
- Partials      101      102       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@artemgavrilov artemgavrilov force-pushed the PG-1907-support-PG-18 branch 2 times, most recently from 53ecbca to 96a09f2 Compare September 11, 2025 16:30
explain.h header file was splitted in PostgreSQL 18, so import required
headers for that version.
In commit 3eea7a0 ExecutorRun hook signature changed. Use new singature
for PG18.
Add build workflow for PostgreSQL 18.
@artemgavrilov artemgavrilov force-pushed the PG-1907-support-PG-18 branch 7 times, most recently from 3925ad8 to d6eff3b Compare September 23, 2025 14:45
There is no need to use unsigned values for hash ids as we cast them to
signed values in SQL output anyways.
This commit address change introduced in dc68515, where SET queries
noramlization rules changed.
@artemgavrilov artemgavrilov force-pushed the PG-1907-support-PG-18 branch 2 times, most recently from 4ebd461 to 2596fc8 Compare September 26, 2025 14:21
This commit address changes made in commits 62d712e, c2da1a5d6, 9fbd53dea and 0f65f3e.
These commits change how PG18 doing jumbling of queries that contain constants list in it.
This commit follows change made in 8928817 commit in PGSS, which in turn
address changes made in 0709b7e commit in PG spinlocks.
007_settings_pgsm_query_shared_buffer.pl test expects ouptut file per
major version. So add one for PostgreSQL 18.

Also add expected column names for 018_column_names.pl test
Add wal_buffers_full value, same as was introduced in PGSS in commit ce5bcc4.
@artemgavrilov artemgavrilov changed the title PG-1907 Add PG18 support PG-1907 PG-18 Support Sep 26, 2025
@artemgavrilov artemgavrilov marked this pull request as ready for review September 26, 2025 16:13
@artemgavrilov artemgavrilov mentioned this pull request Sep 26, 2025
1 task
@artemgavrilov artemgavrilov linked an issue Sep 26, 2025 that may be closed by this pull request
1 task
Copy link
Contributor

@jeltz jeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feel free to merge.

These are the same counters as were intorduced in pg_stat_statements in
commit cf54a2c.
This commet address refactoring made in PostgreSQL codebase in commit
10b7218.
@artemgavrilov artemgavrilov merged commit 8f7868f into main Sep 30, 2025
23 of 27 checks passed
@artemgavrilov artemgavrilov deleted the PG-1907-support-PG-18 branch September 30, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support for postgres 18

2 participants