fix(jobs): handle long log lines and prevent log fetch timeouts#26
Open
eleboucher wants to merge 1 commit intoperfectra1n:mainfrom
Open
fix(jobs): handle long log lines and prevent log fetch timeouts#26eleboucher wants to merge 1 commit intoperfectra1n:mainfrom
eleboucher wants to merge 1 commit intoperfectra1n:mainfrom
Conversation
Fix "bufio.Scanner: token too long" errors when parsing pod logs with lines exceeding 64KB. Also adds timeout for log streaming to prevent controller from hanging on large log streams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Job pods were sticking around after completion because the controller failed to fetch logs. The "bufio.Scanner: token too long" error occurred when log lines exceeded the default 64KB buffer size. Additionally, log fetching had no timeout, causing the controller to hang indefinitely on large log streams, preventing state transitions.
Solution:
to configure scanner buffer size for handling long log lines
timeout for log fetching operations
Changes:
configuration, increased scanner buffer, added timeout context
lines, buffer size configuration, and timeout configuration