fix: support tests outside Tests\ namespace in sharding#1714
Open
YoussefMansour9 wants to merge 3 commits into
Open
fix: support tests outside Tests\ namespace in sharding#1714YoussefMansour9 wants to merge 3 commits into
YoussefMansour9 wants to merge 3 commits into
Conversation
…ypeError in parallel mode When running tests in parallel mode (--parallel), testErroredEvents() can return AfterLastTestMethodErrored events. The existing code assumed all non-Errored events were BeforeFirstTestMethodErrored, causing a TypeError when an AfterLastTestMethodErrored event was passed to fromBeforeFirstTestMethodErrored(). The fix adds an explicit instanceof check for BeforeFirstTestMethodErrored instead of the catch-all else, allowing AfterLastTestMethodErrored events to be safely skipped. Fixes pestphp#1623
YoussefMansour9
force-pushed
the
fix/shard-modular-apps
branch
from
91eb4c4 to
7e798a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running tests in parallel mode (
--parallel),testErroredEvents()can returnAfterLastTestMethodErroredevents. The existing code assumed all non-Errored events wereBeforeFirstTestMethodErrored, causing aTypeErrorwhen anAfterLastTestMethodErroredevent was passed tofromBeforeFirstTestMethodErrored().The fix adds an explicit
instanceofcheck forBeforeFirstTestMethodErroredinstead of the catch-allelse, allowingAfterLastTestMethodErroredevents to be safely skipped.Fixes #1623