Conversation
hartwork
force-pushed
the
resolve-pip-api-dependency
branch
from
4b7b8f1 to
aa5417b
Compare
Owner
|
What do you mean by "resolve use"? Stop depending on it? |
Collaborator
Author
@peterbe yes |
peterbe
approved these changes
Jun 9, 2025
Owner
peterbe
left a comment
peterbe
left a comment
There was a problem hiding this comment.
Sure. If it works, I trust you.
Collaborator
Author
@peterbe thank you! I double-checked all three parts to it again just now. I'll go ahead and merge… |
Collaborator
Author
|
@peterbe go I'll make a pull request for a 1.0.4 release for review now… |
hartwork
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @peterbe,
when trying to package hashin for Gentoo, I noticed its dependency on pip-api that is not packaged in Gentoo, Debian or Ubuntu. The latest release of pip-api is 11 months old, it is using its own copy of
packagingand it does very little over plainpipfor hashin as of today. How do you feel about resolving use of pip-api altogether?My approach below is inspired by these three files of pip-api:
What do you think?
Best, Sebastian