Fix test suite by injecting time dependency for RRSIG validation#13
Merged
Fix test suite by injecting time dependency for RRSIG validation#13
Conversation
Co-authored-by: peterzen <5878500+peterzen@users.noreply.github.com>
Co-authored-by: peterzen <5878500+peterzen@users.noreply.github.com>
Co-authored-by: peterzen <5878500+peterzen@users.noreply.github.com>
Co-authored-by: peterzen <5878500+peterzen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing test cases in test suite
Fix test suite by injecting time dependency for RRSIG validation
Feb 16, 2026
peterzen
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test suite failing because RRSIG records in test data (from 2019) are validated against current time. All signatures expired years ago, causing 6 test failures.
Changes
Time injection in Resolver
timeNow func() time.Timefield toResolver, defaults totime.NowUpdated RRSIG validation
SignedZonenow holds resolver reference to access time functionverifyRRSIG()usesz.resolver.timeNow()instead oftime.Now()newSignedZone()internal to avoid API surface changeTest updates
newResolver()test helperImpact
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.