Skip to content

Fix support for TIMESTAMP (iconst) #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reshke merged 1 commit into from
Feb 26, 2026
Merged

Fix support for TIMESTAMP (iconst) #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions lyx/gram.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lyx/gram.y
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2040,7 +2040,7 @@ opt_varying:
*/

ConstDatetime:
TIMESTAMP TOPENBR SCONST /* ICONST */ TCLOSEBR opt_timezone
TIMESTAMP TOPENBR ICONST /* ICONST */ TCLOSEBR opt_timezone
{

}
Expand Down
8 changes: 7 additions & 1 deletion lyx/yx_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4125,7 +4125,9 @@ func TestCreateTableWithCompositePrimaryKey(t *testing.T) {
{
query: `
CREATE TABLE b
(d TIMESTAMP WITHOUT TIME ZONE)`,
(d TIMESTAMP WITHOUT TIME ZONE,
e TIMESTAMP(0) WITHOUT TIME ZONE DEFAULT NULL
)`,
exp: &lyx.CreateTable{
TableRv: &lyx.RangeVar{
RelationName: "b",
Expand All @@ -4135,6 +4137,10 @@ func TestCreateTableWithCompositePrimaryKey(t *testing.T) {
ColName: "d",
ColType: "TIMESTAMP",
},
&lyx.TableElt{
ColName: "e",
ColType: "TIMESTAMP",
},
},
},
},
Expand Down