Skip to content

Do not require typarray column when auto-registering extensions #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrischall wants to merge 1 commit into from
Closed

Do not require typarray column when auto-registering extensions #632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/io/r2dbc/postgresql/codec/BuiltinDynamicCodecs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public Publisher<Void> register(PostgresqlConnection connection, ByteBufAllocato
}

private PostgresqlStatement createQuery(PostgresqlConnection connection) {
return connection.createStatement(String.format("SELECT oid, typname, typarray FROM pg_catalog.pg_type WHERE typname IN (%s)", getPlaceholders()));
return connection.createStatement(String.format("SELECT oid, typname, * FROM pg_catalog.pg_type WHERE typname IN (%s)", getPlaceholders()));
Copy link
Copy Markdown
Collaborator

@mp911de mp911de Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Care to rewrite the SQL into SELECT * as that is a simpler variant?

}

private static String getPlaceholders() {
Expand Down