[Bug]: Decode WideStrings More Gracefully#13
Merged
jecisc merged 1 commit intopharo-contributions:masterfrom Feb 16, 2026
Merged
[Bug]: Decode WideStrings More Gracefully#13jecisc merged 1 commit intopharo-contributions:masterfrom
jecisc merged 1 commit intopharo-contributions:masterfrom
Conversation
- previously, passing a WideString to Soup would naively convert to bytes assuming an ASCII ByteString, resulting in many null values interleaved with actual characters - Includes a test that failed previously and passes now - Future work might correctly handle the charset and/or include non-ASCII smart quote escaping
Contributor
Author
|
Thanks, @jecisc! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, passing a WideString to Soup would naively convert to bytes assuming an ASCII ByteString, resulting in many null values interleaved with actual characters
Old result:
New result:
But the big payoff is that the old result could result in Soup parsing a hierarchy of HTML tags as one giant SoupString, which is prevented with the fix.