Redo of https://github.com/pharo-vcs/iceberg/pull/1918 (Introduce IceTipRepositoryStatusModel to avoid multiple commit lookups) #2003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of the PR I reverted with a fix so that Iceberg's UI work again.
But this still has a problem. @guillep introduced the IceTipRepositoryStatusModel so that we access less the commit info through FFI. This was based on the idea that #displayColor:, #displayBold: and #displayItalic: are based on the result of #evaluated:. Like this, we could compute the status and descriptions only once and reuse them.
But this does not work like this. Those methods are called directly on the object of the line making the optimization useless because it will still recompute the status and description for each column all the time.
For more info see discussion there: pharo-spec/Spec#1861
So this still needs more work. We need to find a way to cache those info and to know when to invalidate them because the current PR will not bring much improvements