Skip to content

static checking for count_by #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shmax merged 2 commits into from
Sep 3, 2023
Merged

static checking for count_by #46

shmax merged 2 commits into from
Sep 3, 2023

Conversation

@shmax
Copy link
Contributor

@shmax shmax commented Sep 3, 2023

Static checking for Model::count_by magic method.

use test\models\Book;

$numBooks = Book::count_by_name('Walden');
assert(is_int($numBooks));

...now passes static analysis.

@shmax shmax merged commit c8be525 into master Sep 3, 2023
@shmax shmax deleted the dynamic-count-by branch September 3, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shmax