-
Notifications
You must be signed in to change notification settings - Fork 14
Support Relation Iterator #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
============================================
+ Coverage 95.33% 95.44% +0.10%
- Complexity 936 940 +4
============================================
Files 33 33
Lines 2272 2282 +10
============================================
+ Hits 2166 2178 +12
+ Misses 106 104 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I tried valiantly to fix the issue with But in the interest of increasing code coverage enough to pass, I went ahead and implemented variadic lists on Book::where("name = ?" , "Walden") // okay now...which allowed me to remove some exceptions, and it's something we needed to do, anyway. |
With this change, you can now iterate over a
Relationresult:This is accomplished using generators and individual calls to
PDO::fetch, so it can generally result in a memory savings for large result sets.