Fix order()->first() bug #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at capitalization for attribute names are retained. So the short form for New York is now NY instead of ny. test/model/Author, Book, and Venue now have those strtoupper() workarounds in getter/setter methods removed as it's done in Model.php
…rcased in Model.php in order to be case insensitive.
…at capitalization for attribute names are retained. So the short form for New York is now NY instead of ny. test/model/Author, Book, and Venue now have those strtoupper() workarounds in getter/setter methods removed as it's done in Model.php
…rcased in Model.php in order to be case insensitive.
# Conflicts: # lib/Model.php
…cord # Conflicts: # test/ActiveRecordTest.php # test/models/Book.php
…Disable it so that regression does not timeout.
…d#35: Authors table now has a column that is camel cased: firstName Added tests that demonstrate case insensitivity when accessing this firstName column
- Correct link to contributing.md
…vity() is enough.
…cord # Conflicts: # composer.json # scripts/TestCommand.php
…')->find_by_name('Tito') is possible.
…RecordFindByTest.php and ActiveRecordFromTest.php respectively - In doing the above, found and removed duplicated tests - Added test for Relation::testFindBySelect()
1) Author::order('author_id DESC')->find_by_name('Tito'); would clobber order
2) Author::limit(2)->find_by_name('Tito'); would clobber limit
…t have side effects on $this->options
The existing code works.
…cord into RelationDynamicFinders
…. This now passes:
$rel = Author::limit(2)->order('author_id DESC');
$this->assertEquals(Author::last(), $rel->first());
$this->assertEquals(Author::first(), $rel->last());
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
=========================================
Coverage 96.73% 96.73%
Complexity 964 964
=========================================
Files 33 33
Lines 2358 2358
=========================================
Hits 2281 2281
Misses 77 77
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Naw, I had a look at your code and it was perfectly fine. I just renamed your method. 😄 |
shmax
approved these changes
Sep 19, 2023
Contributor
shmax
left a comment
shmax
left a comment
There was a problem hiding this comment.
I'm gonna take your word for it on this one. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://edgeguides.rubyonrails.org/active_record_querying.html#first
the answer is 'yes', so there is a bug in the original test case. This is fixed in the latest commit. If you want to refactor from here, be my guest.