imagedestroy() function is deprecated

[garak]

Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0

Maybe adding some additional PHP versions (beyond 7.4 and 8.1) to the CI could help.
Also, dropping PHP 7 altogether should finally come.

[mlocati]

Also, dropping PHP 7 altogether should finally come.

Why?

[garak]

Because it prevents this library from implementing robust features (mainly about typing). Also, it's clear that at some point it will be impossible to maintain three major versions of PHP at the same time. Finally, the older PHP versions will still be supported in the existing releases.

[mlocati]

Because it prevents this library from implementing robust features

If you see any error, please report them 😉

maintain three major versions of PHP at the same time

So far I don't see big problems

the older PHP versions will still be supported in the existing releases.

What if we have to add bugfixes or new features?

[machour]

@mlocati hey 👋 barging in with my totally unsolicited opinion !

A package usually should evolve with PHP, in order to benefits from new language features, functions, and overall optimisations.

This usually allow dropping some legacy code (like the Image::destroy() that was just introduced). This means less code to maintain, less bugs surface area, and overall less burden for the maintainer: it's really a big +

If a user needs to stay on an older insecure PHP version, use your library, and still benefit from updates, then it's on the user to maintain his own fork(s), and back port bug fixes into the legacy system.

That's the usually rationale.

And then you can take a look at the packagist stats: https://packagist.org/packages/imagine/imagine/php-stats#1 and decide to keep 7.4 support for a little longer.

You'd still benefit from a lot of cool features like null coalesce and typed props👌

Cheers!

[mlocati]

That's the usually rationale.

I don't share this opinion. For example, many packages that make up composer still support PHP 5 3 (eg https://github.com/composer/semver).
Do you think composer is unsafe? If so, file a bug. Otherwise having a library that can be used as is by everyone is a pro, not a con.