Skip to content

Add NoDiscard attribute#5041

Merged
DanielEScherzer merged 4 commits intophp:masterfrom
sasezaki:nodiscard
Feb 27, 2026
Merged

Add NoDiscard attribute#5041
DanielEScherzer merged 4 commits intophp:masterfrom
sasezaki:nodiscard

Conversation

@sasezaki
Copy link
Contributor

@sasezaki sasezaki commented Dec 14, 2025

@sasezaki sasezaki marked this pull request as ready for review December 14, 2025 06:36
Copy link
Member

@DanielEScherzer DanielEScherzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will merge soon if there are no further reviews

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor markup nits.

@DanielEScherzer
Copy link
Member

@Girgias anything remaining before we merge this?

@DanielEScherzer
Copy link
Member

Seeing no objections, merging

@DanielEScherzer DanielEScherzer merged commit 02bee41 into php:master Feb 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants