Skip to content

feat: multiple workers with same file #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 6 commits into from
Sep 9, 2025
Merged

feat: multiple workers with same file #1856

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
34b0e20
Allow multiple workers with the same file.
AlliBalliBaba Sep 4, 2025
9c87760
Fix formatting of duplicate filename check
dunglas Sep 8, 2025
9934bdb
Adds docs.
AlliBalliBaba Sep 9, 2025
886b4ef
Merge branch 'feat/multiple-workers-with-same-path' of https://github…
AlliBalliBaba Sep 9, 2025
60a68b5
suggestions by @alexandre-daubois.
AlliBalliBaba Sep 9, 2025
5aabe13
Update performance.md
dunglas Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion caddy/module.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,10 @@ func (f *FrankenPHPModule) UnmarshalCaddyfile(d *caddyfile.Dispenser) error {
if _, ok := fileNames[w.FileName]; ok {
return fmt.Errorf(`workers in a single "php_server" block must not have duplicate filenames: %q`, w.FileName)
}
fileNames[w.FileName] = struct{}{}

if len(w.MatchPath) == 0 {
fileNames[w.FileName] = struct{}{}
}
}

return nil
Expand Down
Loading