Skip to content

fix: catches panic on invalid status code #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexandre-daubois merged 2 commits into from
Oct 16, 2025
Merged

fix: catches panic on invalid status code #1920

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94ab7de
Catches panic.
AlliBalliBaba Oct 13, 2025
82a14ce
Warns instead.
AlliBalliBaba Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions frankenphp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,9 +475,18 @@ func go_write_headers(threadIndex C.uintptr_t, status C.int, headers *C.zend_lli
current = current.next
}

fc.responseWriter.WriteHeader(int(status))
goStatus := int(status)

if status >= 100 && status < 200 {
// go panics on invalid status code
// https://github.com/golang/go/blob/9b8742f2e79438b9442afa4c0a0139d3937ea33f/src/net/http/server.go#L1162
if goStatus < 100 || goStatus > 999 {
logger.Error(fmt.Sprintf("Invalid response status code %v", goStatus))
Comment thread
AlliBalliBaba marked this conversation as resolved.
Outdated
goStatus = 500
}

fc.responseWriter.WriteHeader(goStatus)

if goStatus >= 100 && goStatus < 200 {
// Clear headers, it's not automatically done by ResponseWriter.WriteHeader() for 1xx responses
h := fc.responseWriter.Header()
for k := range h {
Expand Down