Skip to content

Add GitHub CI#313

Merged
williamdes merged 1 commit intophpmyadmin:masterfrom
J0WI:githubci
Dec 26, 2020
Merged

Add GitHub CI#313
williamdes merged 1 commit intophpmyadmin:masterfrom
J0WI:githubci

Conversation

@J0WI
Copy link
Contributor

@J0WI J0WI commented Nov 6, 2020

Once the tests have been moved upstream we can finally remove Travis.

williamdes
williamdes approved these changes Nov 7, 2020
View reviewed changes
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let me know when I can merge

@J0WI
Copy link
Contributor Author

J0WI commented Nov 9, 2020 •
edited
Loading

You can merge this already and Travis can be removed once docker-library/official-images#9046 is merged.
Edit: You should probably enable GitHub Actions on this repo before merging this.

@tianon tianon mentioned this pull request Nov 10, 2020
Open
@williamdes williamdes requested a review from ibennetch November 10, 2020 08:10
@williamdes williamdes merged commit 7e3ee4e into phpmyadmin:master Dec 26, 2020
williamdes added a commit that referenced this pull request Dec 26, 2020
@williamdes
#313 - Drop Build Images from TravisCI
06cc93a
@williamdes
Copy link
Member

williamdes commented Dec 26, 2020

Merged 🚀
GHA was enabled but I could not know before merging
https://github.com/phpmyadmin/docker/actions/runs/445396186 🟢

Can you help me remove TravisCI because I am not sure all the tests are implemented into GitHub actions

@williamdes williamdes self-assigned this Dec 26, 2020
@williamdes williamdes removed the request for review from ibennetch December 26, 2020 10:54
@J0WI J0WI deleted the githubci branch December 26, 2020 19:44
@J0WI
Copy link
Contributor Author

J0WI commented Dec 26, 2020

Can you help me remove TravisCI because I am not sure all the tests are implemented into GitHub actions

My goal is to merge the tests in docker-library/official-images#9046. The current test setup might be a bit too bloated. A minimal test case or smoke test would already be sufficient.

@williamdes
Copy link
Member

williamdes commented Dec 26, 2020

Can you help me remove TravisCI because I am not sure all the tests are implemented into GitHub actions

My goal is to merge the tests in docker-library/official-images#9046. The current test setup might be a bit too bloated. A minimal test case or smoke test would already be sufficient.

Okay, great idea!
I like minimal and clear things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamdes williamdes williamdes approved these changes

Assignees

@williamdes williamdes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@J0WI @williamdes