Init container before DataProvider is called

[staabm]

without this fix we saw errors like

➜  phpstan-src git:(fix-tests) ✗ time vendor/bin/phpunit tests/PHPStan/Type/Generic/TemplateTypeMapTest.php --debug
PHPUnit Started (PHPUnit 11.5.39 using PHP 8.3.25 (cli) on Darwin)
Test Runner Configured
Bootstrap Finished (/Users/staabm/workspace/phpstan-src/tests/bootstrap.php)
Event Facade Sealed
Data Provider Method Called (PHPStan\Type\Generic\TemplateTypeMapTest::dataUnionWithLowerBoundTypes for test method PHPStan\Type\Generic\TemplateTypeMapTest::testUnionWithLowerBoundTypes)


An error occurred inside PHPUnit.

Message:  (no message)
Location: /Users/staabm/workspace/phpstan-src/src/Reflection/ReflectionProviderStaticAccessor.php:22

#0 /Users/staabm/workspace/phpstan-src/src/Type/ObjectType.php(1720): PHPStan\Reflection\ReflectionProviderStaticAccessor::getInstance()
#1 /Users/staabm/workspace/phpstan-src/src/Type/ObjectType.php(561): PHPStan\Type\ObjectType->getClassReflection()
#2 /Users/staabm/workspace/phpstan-src/src/Type/TypeCombinator.php(1213): PHPStan\Type\ObjectType->isSuperTypeOf(Object(PHPStan\Type\ObjectType))
#3 /Users/staabm/workspace/phpstan-src/src/Type/Generic/TemplateTypeMap.php(133): PHPStan\Type\TypeCombinator::intersect(Object(PHPStan\Type\ObjectType), Object(PHPStan\Type\ObjectType))
#4 /Users/staabm/workspace/phpstan-src/tests/PHPStan/Type/Generic/TemplateTypeMapTest.php(34): PHPStan\Type\Generic\TemplateTypeMap->union(Object(PHPStan\Type\Generic\TemplateTypeMap))
#5 /Users/staabm/workspace/phpstan-src/vendor/phpunit/phpunit/src/Metadata/Api/DataProvider.php(183): PHPStan\Type\Generic\TemplateTypeMapTest::dataUnionWithLowerBoundTypes()
#6 /Users/staabm/workspace/phpstan-src/vendor/phpunit/phpunit/src/Metadata/Api/DataProvider.php(69): PHPUnit\Metadata\Api\DataProvider->dataProvidedByMethods('PHPStan\\Type\\Ge...', 'dataUnionWithLo...', Object(PHPUnit\Metadata\MetadataCollection))
#7 /Users/staabm/workspace/phpstan-src/vendor/phpunit/phpunit/src/Framework/TestBuilder.php(47): PHPUnit\Metadata\Api\DataProvider->providedData('PHPStan\\Type\\Ge...', 'testUnionWithLo...')
#8 /Users/staabm/workspace/phpstan-src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(508): PHPUnit\Framework\TestBuilder->build(Object(ReflectionClass), 'testUnionWithLo...', Array)
#9 /Users/staabm/workspace/phpstan-src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(109): PHPUnit\Framework\TestSuite->addTestMethod(Object(ReflectionClass), Object(ReflectionMethod), Array)
#10 /Users/staabm/workspace/phpstan-src/vendor/phpunit/phpunit/src/TextUI/Configuration/TestSuiteBuilder.php(121): PHPUnit\Framework\TestSuite::fromClassReflector(Object(ReflectionClass))
#11 /Users/staabm/workspace/phpstan-src/vendor/phpunit/phpunit/src/TextUI/Configuration/TestSuiteBuilder.php(58): PHPUnit\TextUI\Configuration\TestSuiteBuilder->testSuiteFromPath('/Users/staabm/w...', Array)
#12 /Users/staabm/workspace/phpstan-src/vendor/phpunit/phpunit/src/TextUI/Application.php(412): PHPUnit\TextUI\Configuration\TestSuiteBuilder->build(Object(PHPUnit\TextUI\Configuration\Configuration))
#13 /Users/staabm/workspace/phpstan-src/vendor/phpunit/phpunit/src/TextUI/Application.php(182): PHPUnit\TextUI\Application->buildTestSuite(Object(PHPUnit\TextUI\Configuration\Configuration))
#14 /Users/staabm/workspace/phpstan-src/vendor/phpunit/phpunit/phpunit(104): PHPUnit\TextUI\Application->run(Array)
#15 /Users/staabm/workspace/phpstan-src/vendor/bin/phpunit(122): include('/Users/staabm/w...')
#16 {main}

[staabm]

in case extension developer have to deal with the same race condition problems, we could instruct them to use the extension, which takes care of bootstrapping/re-building the container for them

[staabm]

I think we should instruct PHPStan to not scan the files in src/Testing/PHPUnit/ for all PHPVersion which use old-phpunit.

have no idea yet how todo the php version specific config

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

Why is it excluded from analysis? It ships with the PHAR, it should pass the analysis.

[ondrejmirtes]

The name should be PHPStanPHPUnitExtension

[ondrejmirtes]

PHP version specific config is already happening, check the files in build/. There's ignore-by-php-version...

[staabm]

There's ignore-by-php-version...

see https://github.com/phpstan/phpstan-src/actions/runs/17822286344/job/50667691251?pr=4342

there are non-ignorable errors.. it seems PHPStan is smart enough to realize that PHPUnit 9.x does not contain the interface the extension is using

[ondrejmirtes]

You can put excludePaths into a new neon file and add it to includes if the PHPUnit version is older than 10.

[staabm]

You can put excludePaths into a new neon file

used the already existing old-phpunit.neon for that.

[ondrejmirtes]

Super nice, thank you!