Use separate cache for CachedParser->parseFile() #4647
Draft
+11
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
cached-parser
branch
from
b75424d to
fbfe454
Compare
staabm
commented
Dec 23, 2025
| /** | ||
| * @return Node\Stmt[] | ||
| */ | ||
| public function parseString(string $sourceCode): array |
Contributor
Author
There was a problem hiding this comment.
hmm I wonder whether/why we need this parseString function. it seems its only used from tests and everywhere else we read a file to pass the contents into parseString.
I think we could remove some unnecessary file-read operations by dropping parseString and just use parseFile everywhere with PHPStan 3.x ... wdyt?
Member
|
I have to remember the reason for this but I think there is one. The currently failing test testParseTheSameFileWithDifferentMethod might be showing precisely that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.