Fix phpstan/phpstan#14333: Setting an array key doesn't update a reference#5257

Merged

VincentLanglet merged 22 commits intophpstan:2.1.xfrom

phpstan-bot:create-pull-request/patch-bsc1yhl

Mar 23, 2026

Commits on Mar 22, 2026

Fix phpstan/phpstan#14333: Setting an array key doesn't update a reference
VincentLanglet
committed
Add test for nested array reference tracking limitation

authored and
VincentLanglet
committed
Skip implicit-key by-ref tracking when index is uncertain due to non-constant keys

authored and
VincentLanglet
committed
Simplify
VincentLanglet
committed
Fix
VincentLanglet
committed
Implement nested array reference tracking

authored and
VincentLanglet
committed
Simplify
VincentLanglet
committed
Add comment explaining why implicitIndex is set to null for non-constant keys

authored and
VincentLanglet
committed
Move intertwined ref preservation from assignVariable to invalidateExpression

authored and
VincentLanglet
committed
Move intertwined ref preservation condition into shouldInvalidateExpression

authored and
VincentLanglet
committed
Simplify
VincentLanglet
committed
Rename and simplify isDimFetchPathReachable to absorb nested check

authored and
VincentLanglet
committed
Add failing test
VincentLanglet
committed
Fix lint
VincentLanglet
committed
Prevent circular back-propagation of intertwined refs during variable reassignment

authored and
VincentLanglet
committed
Add test for multi-scalar key values in array by-ref tracking

authored and
VincentLanglet
committed
Use toArrayKey() for proper array key coercion and add tests for multiple scalar keys

authored and
VincentLanglet
committed
Add tests
VincentLanglet
committed
Use toArrayKey() for proper array key coercion and add tests for multiple scalar keys

authored and
VincentLanglet
committed
Remove dim expression coercion, fix HasOffsetValueType key coercion instead

authored and
VincentLanglet
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix phpstan/phpstan#14333: Setting an array key doesn't update a reference#5257

Fix phpstan/phpstan#14333: Setting an array key doesn't update a reference#5257
VincentLanglet merged 22 commits intophpstan:2.1.xfrom
phpstan-bot:create-pull-request/patch-bsc1yhl

Commits on Mar 22, 2026

Fix phpstan/phpstan#14333: Setting an array key doesn't update a reference

Add test for nested array reference tracking limitation

Skip implicit-key by-ref tracking when index is uncertain due to non-constant keys

Simplify

Fix

Implement nested array reference tracking

Simplify

Add comment explaining why implicitIndex is set to null for non-constant keys

Move intertwined ref preservation from assignVariable to invalidateExpression

Move intertwined ref preservation condition into shouldInvalidateExpression

Simplify

Rename and simplify isDimFetchPathReachable to absorb nested check

Add failing test

Fix lint

Prevent circular back-propagation of intertwined refs during variable reassignment

Add test for multi-scalar key values in array by-ref tracking

Use toArrayKey() for proper array key coercion and add tests for multiple scalar keys

Add tests

Use toArrayKey() for proper array key coercion and add tests for multiple scalar keys

Remove dim expression coercion, fix HasOffsetValueType key coercion instead

Commits on Mar 23, 2026

Check isConstantScalarValue() on coerced array key type in HasOffsetValueType

Apply toArrayKey() before isConstantScalarValue() check in HasOffsetValueType, add integer-range key tests