Allow random access to photos in an album#365
Open
partnerinflight wants to merge 1 commit intopicklepete:masterfrom
Open
Allow random access to photos in an album#365partnerinflight wants to merge 1 commit intopicklepete:masterfrom
partnerinflight wants to merge 1 commit intopicklepete:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
For iCloud photo libraries with thousands of photos, fetching metadata for every photo in order to iterate through them becomes prohibitive very quickly. Therefore, we need random access to the photos in a photo album.
Since iCloud won't allow fetching just one photo metadata, we fetch 2 -- just enough to avoid an error.
Also refactored existing metadata fetching code to use the same underlying fetch function.
Type of change
Example of code:
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: