This repository was archived by the owner on Sep 9, 2024. It is now read-only.
ensure that globals includes process and console#18
Merged
pierrec merged 1 commit intopierrec:masterfrom Jul 6, 2019
Merged
Conversation
The code attaches global properties to the sandbox context by iterating over all the enumerable properties of `global`. However, in node v10, `console` switched [to being non-enmuerable][1]. This means that for users of this library with node>10, any `console.log`s in evaluated scripts will fail. This commit fixes this issue by manually attaching console to the sandbox (when globals are being used). A test has been added. Prior to the change to eval.js, the test would pass in node v8 but fail in v10 and v12. Also, the tests were already failing in v12, because in v12 `process` also became non-enumerable. I've applied a similar fix to `process` to ensure that it's always available too. [1]: nodejs/node#17708
Contributor
Author
|
Thanks for merging this, @pierrec. Can you please cut a new release? |
Contributor
Author
|
Ah, I see you already did. Thanks! |
teamdandelion
pushed a commit
to teamdandelion/static-site-generator-webpack-plugin
that referenced
this pull request
Jul 6, 2019
The `eval` dependency has a bug in node v10 and above, where the `console` won't be available to scripts, even if globals are supposed to be available. See: pierrec/node-eval#18. For users of static-site-generator-webpack-plugin, this means that index scripts which contain logging statements will not work properly. The bug is fixed in eval v0.1.4, so we just need to update the dependency. Test plan: `yarn test` still passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code attaches global properties to the sandbox context by iterating
over all the enumerable properties of
global. However, in node v10,consoleswitched to being non-enmuerable. This means that forusers of this library with node>10, any
console.logs in evaluatedscripts will fail.
This commit fixes this issue by manually attaching console to the
sandbox (when globals are being used). A test has been added. Prior to
the change to eval.js, the test would pass in node v8 but fail in v10
and v12.
Also, the tests were already failing in v12, because in v12
processalso became non-enumerable. I've applied a similar fix to
processtoensure that it's always available too.