Draft
Conversation
- Add --pinecone_multi_namespace flag to enable benchmarking across all namespaces - Auto-discover all populated namespaces in existing indexes - Distribute requests evenly across namespaces using round-robin - Add validation to ensure multi-namespace mode only works with existing populated indexes - Require --skip_populate when using multi-namespace mode - Aggregate metrics across all namespaces (same format as single-namespace mode) - Update Pinecone README with multi-namespace documentation
…namespaces This fixes test timeouts by using a direct API call to check namespace existence instead of iterating through all namespaces. The previous implementation was inefficient and caused timeouts in CI tests. - Changed check_namespace_exists() to use describe_namespace() API - Handles NotFoundException when namespace doesn't exist - Much faster and more efficient for single namespace checks - No impact on multi-namespace functionality (uses _discover_all_namespaces)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Describe the purpose of this change. What problem is being solved and why?
Enables benchmarking for existing, populated, multi-namespace Pinecone indexes.
Solution
Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.
Workload is spread evenly across namespaces. Results are aggregated for metrics.
Type of Change
Test Plan
Describe specific steps for validating this change.
Tested on existing test suite