Skip to content

grafana: add max ping latency metric#1070

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
yibin87:add_max_ping
Apr 7, 2026
Merged

grafana: add max ping latency metric#1070
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
yibin87:add_max_ping

Conversation

@yibin87
Copy link
Copy Markdown
Contributor

@yibin87 yibin87 commented Apr 7, 2026

close: #1071

Summary

  • keep the existing Ping Latency series for raw probe duration
  • add a Max Ping Latency series using max_over_time on probe_duration_seconds over 1 minute for the selected PingJobHost
  • align the new series with the BLACKER_ping_latency_more_than_1s alert logic while preserving PingJobHost filtering

Validation

  • git diff --check
  • reviewed the updated Grafana panel JSON diff

Signed-off-by: yibin87 <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot requested review from asddongmen and liubog2008 April 7, 2026 02:57
@pingcap-cla-assistant
Copy link
Copy Markdown

pingcap-cla-assistant bot commented Apr 7, 2026

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/S label Apr 7, 2026
@yibin87
Copy link
Copy Markdown
Contributor Author

yibin87 commented Apr 7, 2026

/cc @csuzhangxc

@ti-chi-bot ti-chi-bot bot requested a review from csuzhangxc April 7, 2026 03:30
@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 7, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 7, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-07 06:39:20.436227629 +0000 UTC m=+851965.641587676: ☑️ agreed by csuzhangxc.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 7, 2026
@ti-chi-bot ti-chi-bot bot merged commit 9d821c8 into pingcap:master Apr 7, 2026
2 checks passed
@yibin87
Copy link
Copy Markdown
Contributor Author

yibin87 commented Apr 7, 2026

/cherry-pick release-8.5

@ti-chi-bot
Copy link
Copy Markdown
Member

@yibin87: new pull request created to branch release-8.5: #1072.

Details

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new ping latency metrics to align with alert rule

3 participants