Skip to content

cluster: replace TextToMetricFamilies with regexp #2695

Merged
xhebox merged 4 commits intopingcap:masterfrom
xhebox:master
Mar 27, 2026
Merged

cluster: replace TextToMetricFamilies with regexp #2695
xhebox merged 4 commits intopingcap:masterfrom
xhebox:master

Conversation

@xhebox
Copy link
Copy Markdown
Collaborator

@xhebox xhebox commented Mar 27, 2026

What problem does this PR solve?

close #2680

What is changed and how it works?

  1. add profile-dir to profile tiup
  2. replace memory consuming TextToMetricFamilies

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

xhebox added 2 commits March 27, 2026 12:07
g
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from srstack March 27, 2026 04:09
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 27, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 11.42857% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.35%. Comparing base (c757251) to head (65fe171).

Files with missing lines Patch % Lines
components/cluster/command/root.go 2.56% 38 Missing ⚠️
pkg/cluster/spec/util.go 58.33% 2 Missing and 3 partials ⚠️
components/dm/spec/logic.go 0.00% 2 Missing ⚠️
pkg/cluster/spec/alertmanager.go 0.00% 1 Missing ⚠️
pkg/cluster/spec/cdc.go 0.00% 1 Missing ⚠️
pkg/cluster/spec/dashboard.go 0.00% 1 Missing ⚠️
pkg/cluster/spec/drainer.go 0.00% 1 Missing ⚠️
pkg/cluster/spec/grafana.go 0.00% 1 Missing ⚠️
pkg/cluster/spec/monitoring.go 0.00% 1 Missing ⚠️
pkg/cluster/spec/pd.go 0.00% 1 Missing ⚠️
... and 10 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2695   +/-   ##
=======================================
  Coverage   42.34%   42.35%           
=======================================
  Files         424      424           
  Lines       47015    47018    +3     
=======================================
+ Hits        19908    19911    +3     
+ Misses      24425    24418    -7     
- Partials     2682     2689    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

xhebox added 2 commits March 27, 2026 12:34
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox merged commit 5ac1c78 into pingcap:master Mar 27, 2026
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TextToMetricFamilies is causing memory troubles

2 participants